Página com um QR Code, usando apenas HTML e CSS

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  • It would be better if you give the properties to the body instead of the .container.

  body {
    background-color: #d5e1ef;
    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
  }
  

  • If you use max-width, the card will be responsive
  • You'd better update padding in this way:

  .box {
    background-color: #fff;
    padding: 15px;
    /* padding: 5px; */
    /* padding-top: 15px; */
    /* padding-bottom: 35px; */
    /* margin: 0px; */
    border-radius: 15px;
    max-width: 300px;
    text-align: center;
  }
  

  • In addition to that above, in order to make the card responsive and the image positioned completely on the card, you'd better add width: 100% and display: block; to the img.

  img {
    /* width: 270px; */
    width: 100%;
    display: block;
    /* height: 270px; */
    /* margin: 0px; */
    /* padding: 0; */
    /* border-radius: 15px; */
    /* margin-bottom: 10px; */
  }
  

  • You need to update font-size of text as rem or px instead of vw because they aren't visible when it is responsive

  h3 {
    /* font-size: 1.5vw; */
    font-size: 1.5rem;
  }
  

  p {
    /* font-size: 1vw; */
    font-size: 1rem;
  }
  

  • You don't need to use .container anymore and you can remove it to avoid repetition

  /* .container {
    display: flex;
    justify-content: center;
    align-items: center;
    height: 600px;
  } */
  

  Hope I am helpful. :)

  Marked as helpful

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0