Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey there!👋 Here are some suggestions to help improve your code:
-
To better identify the main content of you site you will want to encase your entire component inside a Main Element.
-
The car images/icons in this component are purely decorative; They add no value. So their Alt Tag should left blank and have an aria-hidden=“true” to hides them from assistive technology.
-
The “SEDANS”, “SUVS” and “LUXURY” are headings so they need be wrapped in a Heading Element. Since each heading in this card has the same level of importance an <h2> Heading will be the best choice.
-
Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
0@byhenriquesilvaPosted about 2 years ago@vcarames Hi, thank you very much for your feedback, it will help me a lot in my next practice.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord