Perfume project with HTML and CSS

Community feedback

• 

  Azhar•600

  @azhar1038Posted over 2 years ago

  Hi Benjamin,

  Github pages don't work like this. You have to create a repo of name benjaegle.github.io Then create an index.html inside it. Check this official guide

  Also you can create folders inside it and host all your challenges through the same repo. You may take a look at how I did it azhar1038/azhar1038.github.io

  Hope it helps :)

  Marked as helpful

  0

  ---

  

  Benjamin•20

  @BenjaeglePosted over 2 years ago

  @azhar1038

  Hello,

  I have followed another solution for the moment so that everyone can see my solution correctly!

  Do you have any comments on the project?

  Have a nice day!

  0

  

  Azhar•600

  @azhar1038Posted over 2 years ago

  @Benjaegle Great!

  But it seems your image in mobile view is getting stretched out as you have a fixed height set.

  The media query when you change to mobile view is different from when you switch the source in picture, they should be same.

  The border radius that you are applying on image in desktop view is not getting switched in mobile view, I will recommend to uses overflow: hidden on card instead of giving brder radius to image

  You have used article for image and the text part, I don't think article is the correct tag for this. Articles are usually the part that can be represented completely separate. Check the MDN docs. Maybe you can use section for text part but image can be put on normal div I will say.

  Your cart icon is not visible, it seems it is not present in server because other images are showing up correctly, so I don't think it is path problem. Also for decoration type images you can just use alt="" and aria-hidden

  The biggest problem I noticed was your site was suddenly becoming unreachable again and again but was coming back after 3-4 minutes. Maybe it is not correctly hosted?

  Hope it helps :)

  0
• 

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  👾Hello Benjamin, congratulations for your solution!

  You live site isn't displaying yet and I can see you're having a hard time with Github Pages. My advice for you is to use vercel.com or netlify.com that are services for live sites with a really user-friendly interface and with a quick setup. All you need to do is connect your Github account, import the repository and deploy the live site.

  Why you don't try that? Giving vercel or netlify a try.

  Once you've your live site on, you can update the project going to solution > challenge hub > update solution and drop the new solution link. This way we can se your live site and give tips for you!

  Try that and say me if works.

  Marked as helpful

  0

  ---

  

  Benjamin•20

  @BenjaeglePosted over 2 years ago

  @correlucas Hello!

  Thank you very much for your answer! Indeed I have trouble with github! With 15 days of codes and a lot of notions to integrate, I'm struggling a bit!

  I pasted the netlify link in my profile, it should work now!

  On the other hand I do not understand why my shopping cart icon does not load!

  Thanks a lot, I'm looking forward to your feedback on the project itself :)

  1

  

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  @Benjaegle Happy to hear that! I saw that there's no icon inside the assets folder, maybe this is the reason isn't displaying, remember to put ./ before the folder to import, use ever a dot before dash to indicate that the file is inside a folder and ../ if is in a subfolder.

  0

  

  Benjamin•20

  @BenjaeglePosted over 2 years ago

  @correlucas

  Thank you so much!

  Normally this should be ok, do you have any comments on the rendering of the project?

  0