Perfume Product Listing

Community feedback

• 

  Francisco Carrillo•5,540

  @frank-itachiPosted almost 2 years ago

  Hello there 👋. You did a good job!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.
  • If your code has different sections that have a specific like a navigation, article, sections or footer, it’s a good practice to enclose those parts with HTML5 landmarks. For example, you could use a <footer> tag to wrap a footer section.
  • The heading order is important in the html structure so try to always start your headings with an <h1> tag and then you can decrease by one if you need to use more heading in your html code.
  • Since the mobile design has a different image, you can use the <picture> tag that allows you to interchange the images depending of the viewport size. Red more about this awesome tag here

  CSS 🎨:

  • You can use grid or flexbox to center the content no matter the viewport size. Since I use grid to achieve such purpose, you can do the following:

  body {
  	min-height: 100vh;
          display: grid;
  	align-items: center;
  	justify-content: center;
  }
  

  As I said, you can use flexbox to center the content and it will work as well.

  body {
  	min-height: 100vh;
          display: flex;
  	align-items: center;
  	justify-content: center;
  }
  

  • Avoid using absolute length units px, especially for font-size and width properties, because they are not relative to anything else so that means they will always be the same size. Instead, you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g., the parent container. You can dig up about it here

  I hope you find it useful! 😁😁 Above all, the solution you submitted is great👌!

  Happy <coding /> 😎!

  Marked as helpful

  0

  ---

  

  Lucas-DevOp•20

  @Lucas-DevOpPosted almost 2 years ago

  @frank-itachi Thank you!

  0
• 

  Sakib Ahmed•240

  @devvsakibPosted almost 2 years ago

  wow! perfect shot

  0

  ---

  

  Lucas-DevOp•20

  @Lucas-DevOpPosted almost 2 years ago

  @devvsakib Thank you!

  0