Perfume Product Card Solution

Community feedback

• 

  Alptuğ•30

  @carpediem23Posted 11 months ago

  It's looking well. You use semantic elements and grid well too. Congratulations 🤘

  Note: On the 480px size, the card snapping to left and right side. You able to adjust that maybe.

  Marked as helpful

  1

  ---

  

  Yavuz KARAKUŞ•50

  @yavuzkarakusPosted 11 months ago

  Yes, instructor, ⚡ I just realized that there is distortion in 480px. I will edit it as soon as possible.🚀 Your feedback and teachings are very important to me, thank you. 🙏🏼 @carpediem23

  0
• 

  Bryan Li•3,530

  @Zy8712Posted 11 months ago

  Your site looks great! The only thing I feel you should add in is <main> tags to wrap around you content for accessibility purposes. One thing I think you should change is your choice of header tags. I see that you used <h2> and <h3>, but header tags are meant to be used in order starting from <h1>, so it would be better if you changed the tags used.

  Marked as helpful

  1

  ---

  

  Yavuz KARAKUŞ•50

  @yavuzkarakusPosted 11 months ago

  Thank you very much for your feedback, Bryan Li. 🙏🏼 I tried to use section as much as possible in HTML, it didn't occur to me to section it as main. On the other hand, I really didn't know which of the heading elements to start with. Since there are real world examples, I didn't use the h1 element, thinking that there must be a header. 🙃 Thank you again. @Zy8712 ⚡

  0
• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 11 months ago

  Very nice job on this project, @yavuzkarakus.

  Semantic HTML and responsible for mobile and desktop screen sizes.

  Marked as helpful

  1

  ---

  

  Yavuz KARAKUŞ•50

  @yavuzkarakusPosted 11 months ago

  Thank you for your feedback. ✌🏻🙃 @danielmrz-dev

  1