Perfume MediaQ

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Wrap the content of the html in the main tag to fix the accessibility issues.

  there is no need to give the body a max-width , max-height and padding values. To center .container/main on the page using flexbox or grid, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center .container on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center .container on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0
• 

  Abdessamad•210

  @styrexxPosted almost 2 years ago

  Hello there 👋. You did a good job!

  There are a few changes you can make to make your solution better.

  • You can use a grid to center the content no matter the viewport size. You can do the following:

  body {
  	min-height: 100vh;
          display: grid;
  	align-items: center;
  	justify-content: center;
  }
  

  • Fix the issues that have been reported.

  I hope you find this helpful.

  0