Perfume Card with HTML, CSS, SCSS, BEM

Community feedback

• 

  Francisco Carrillo•5,540

  @frank-itachiPosted over 1 year ago

  Hello there 👋. Congratulation for completing the challenge👍!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the <div class="card"> content in the <main> tag.
  • You could also use the <picture> tag that allows you to interchange the images depending of the viewport size. Red more about this awesome tag here.
  • In this case there is only one <footer> tag so you can get rid of the class="footer" attribute of it and use the selector tag in you CSS stylesheet.

  I hope you find it useful! 😄 Above all, you did a good job!

  Happy <coding /> 😎!

  Marked as helpful

  1

  ---

  

  Adam•20

  @adamstopinskiPosted over 1 year ago

  @frank-itachi

  Thank you very much for tips, appreciate it much! Didn't know before that there is something like <picture> tag, looking good. I have to experience with it a little. About class footer, its just my weird behaviour to classed every tag and element cause i just like it, is this any problem or just less coding? :)

  Best regards :)

  0