@danielmrz-dev
Posted
Hello @AlexaGabriel!
Your solution looks great!
I have just a couple of suggestions for improvement:
- Avoid using percentage or viewport height/width based values to set an element's
width
andheight
. This can cause bugs and make your element grow too much on some screen sizes or not grow enough on others.
To fix that, use max-width
with fixed values, like pixels to set a limit. By doing that, your project remains responsive, but it won't grow too much, because you set a limit for it.
For height
, just add the content and let the container adapt. Most times it'll be just the size it needs to be and you can adjust what you need with margins
and paddings
in the elements inside of it.
I hope it helps!
Other than that, you did an excelent job!
Marked as helpful
@AlexaGabriel
Posted
@danielmrz-dev It was something I had a little doubt about, thanks for the feedback, it helped me a lot