Design comparison
SolutionDesign
Community feedback
- @aguscorvoPosted 2 months ago
Congrats on finishing the challenge!
Here are some suggestions or tips to improve the solution:
- How about using semantic HTML? I noticed that the main tag is missing, for example.
- The purpose of the alt property is to describe the image.
- Some text is using the wrong font family, such as the title, price, or button.
- "Perfume" should be in uppercase.
- Responsive is working properly! However, be aware that the image borders change in the mobile view.
- I noticed a few typos in the CSS classes, or they may be incorrectly named (for example, using "buttons" for the price div). While this may not be an issue now, it could be confusing when you revisit the code, especially when working in a team.
Happy coding! :)
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord