@correlucas
Posted
👾Hello @Mahmoudelhousiny, Congratulations on completing this challenge!
Your solution its almost done and I’ve some tips to help you to improve it:
1.Improve the card's overall look by adding the rounded borders to the component and also the image using border-radius: 15px
- Add rounded borders to the left side of the image with
border-radius: 15px 0px 0px 15px; - Then do the same thing for the component but in the opposite borders
border-radius: 0px 15px 15px 0px;
2.Add the correct font for the main heading of this component. First of all you need to choose the font using Google Fonts https://fonts.google.com/ and import the code to drop on your CSS/HTML:
This is the font for the H1: font-family: 'Fraunces', serif;. There's two ways to import the font:
- Using the html and inserting it to the
<head>
<head>
<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Fraunces:opsz,[email protected],700&display=swap" rel="stylesheet">
</head>
- Using the CSS and adding to the first line of the CSS sheet:
@import url('https://fonts.googleapis.com/css2?family=Fraunces:opsz,[email protected],700&display=swap');
3.Using <picture> you’ve more control over the elements and its better than using the product image as <img> or background-image. Look that for SEO and search engine reasons it isn't a better practice to import this product image with CSS since this will make it harder to the image. You can manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device (phone / computer) Here’s a guide about how to use picture: https://www.w3schools.com/tags/tag_picture.asp
See the example below:
<picture>
<source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
<img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
</picture>
✌️ I hope this helps you and happy coding!
Marked as helpful
