Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Password-Generator

jyoung0930β€’ 135

@jyoung0930

Desktop design screenshot for the Password generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback is welcomed.

Community feedback

Minh Leβ€’ 200

@ledminh

Posted

Hello jyoung0930,

I love that you safeguarded your app from error by requiring character length must be greater than 5. Here is my idea for improvement, you can count how many options are checked and set it to be the minimum value character length must have.

1

jyoung0930β€’ 135

@jyoung0930

Posted

@ledminh great idea! Thanks!

0

Account Deleted

Hello jyoung0930 πŸ‘‹

Your project is very clean and cool, but there is a little bit improvement to make on Javascript aspect.

You should avoid making long constants array with you have possibility to generate by itself :

const lowerCaseLetters = [
  "a",
  "b",
  "c",
  "d",
  "e",
  "f",
  "g",
  "h",
  "i",
  "j",
  "k",
  "l",
  "m",
  "n",
  "o",
  "p",
  "q",
  "r",
  "s",
  "t",
  "u",
  "v",
  "w",
  "x",
  "y",
  "z",
];

can be simplified to

const lowerCaseLetters = [];
for (let i=97 ; i <= 122 ; i++) 
lowerCaseLetters.push(String.fromCharCode(i));

Otherwise, congratulation for your achievement πŸŽ‰

1

jyoung0930β€’ 135

@jyoung0930

Posted

@bjordandev thanks! That’s a much better way of doing it.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord