Password-Generator

Community feedback

• 

  Minh Le•200

  @ledminhPosted about 2 years ago

  Hello jyoung0930,

  I love that you safeguarded your app from error by requiring character length must be greater than 5. Here is my idea for improvement, you can count how many options are checked and set it to be the minimum value character length must have.

  1

  ---

  

  jyoung0930•135

  @jyoung0930Posted about 2 years ago

  @ledminh great idea! Thanks!

  0
• Account deleted

  Hello jyoung0930 👋

  Your project is very clean and cool, but there is a little bit improvement to make on Javascript aspect.

  You should avoid making long constants array with you have possibility to generate by itself :

  const lowerCaseLetters = [
    "a",
    "b",
    "c",
    "d",
    "e",
    "f",
    "g",
    "h",
    "i",
    "j",
    "k",
    "l",
    "m",
    "n",
    "o",
    "p",
    "q",
    "r",
    "s",
    "t",
    "u",
    "v",
    "w",
    "x",
    "y",
    "z",
  ];
  

  can be simplified to

  const lowerCaseLetters = [];
  for (let i=97 ; i <= 122 ; i++) 
  lowerCaseLetters.push(String.fromCharCode(i));
  

  Otherwise, congratulation for your achievement 🎉

  1

  ---

  

  jyoung0930•135

  @jyoung0930Posted about 2 years ago

  @bjordandev thanks! That’s a much better way of doing it.

  0