Design comparison
Solution retrospective
Hi, any suggestions are welcome ☺
Community feedback
- @ledminhPosted about 2 years ago
I really love the fact that you build this project on vanilla JS. It is the best way to learn javascript. I tried it once on this personal project, it was a very fulfilling experience.
And here are some suggestions for improvement. First, the Generate button should have another outlook when it is disabled. Second, I see that sometimes the generated password does not satisfy all of the requirements. I checked on lowercase, uppercase, and number but the password only contains uppercase and number. Third, to satisfy all rules, password's length should be equal or greater than the number of rules.
I hope you find it helpful.
Marked as helpful0 - @Duyen-codesPosted about 2 years ago
Hei, I wonder how you learned JS so well? Could you share any resources you have used please. I'd really appreciate that.
0@Hanka8Posted about 2 years ago@Duyen-codes Hi, Eloquent javascript for theory, Codewars for practising and some videos on youtube for seeing how it works in real projects. You can also check this channel - some concepts are nicely explained there. Hope it helps!
1@Duyen-codesPosted about 2 years ago@Hanka8 Thanks so much for sharing! I'd like to connect and do pair coding with you if possible.
1 - @Duyen-codesPosted about 2 years ago
Well done!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord