Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Avsecam, great work on this challenge! 😉
Here are a few tips for improve your code:
- to make it look as close to the design as possible decrease
border-radius
of image of flag - if you want to use the title for the
href
attribute you have to parse it inurl
, it can give problems creating links with empty spaces or special characters - if I type a query that doesn't give any results, open the first country of home page, try adding a "no results" message
- I would also add a query reset button, I find it very convenient
Overall you did well 😁 Hope this help!
Marked as helpful1@avsecamPosted over 2 years agoThanks @denielden 😁
- I was trying to make the elements have a neumorphic look, so thats why my design was a bit different with the border-radii
- I will absolutely work on a no results page and a query reset, thanks for the ideas! 😇
1 - to make it look as close to the design as possible decrease
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord