pagina responsiva usando flexboxe scss

Community feedback

• 

  Kelvin•770

  @githukelvinPosted over 2 years ago

  Hi @dnper

  I just wanted to give you some hits to make the solution

  -body .container This is the class you used you can remove margin-top: 50px; margin-left: 20%; replace it with margin:10rem auto ; to center your container. -Add some landmarks on your website <header></header> <main></main> <footer></footer> this is for accesibility.

  --Cart image should be white.

  Happy coding

  Marked as helpful

  1

  ---

  

  Daniel Pereira•30

  @dnperPosted over 2 years ago

  @githukelvin muito obrigado pelo feedback, vou fazer outros desafios pra praticar mais ja que comecei a pouco tempo a estudar

  quanto a imagem do carrinho nao achei branca.

  1
• Account deleted

  hi @dnper! great work!

  I'll give you some suggestions to improve your code:

  • Document should have one main landmark, which should enclose the main part of your code, you could change that main <section> tag to a <main> tag

  • Heading levels should only increase by one, and you should have only one main title(<h1> tag) on your page, could you review those <h3> and <h4> tags in your code and decrement them by one

  I hope this feedback has been useful to you! keep coding :)

  Marked as helpful

  1

  ---

  

  Daniel Pereira•30

  @dnperPosted over 2 years ago

  @nachogonzalia foi muito util sim, muito obrigado pelas dicas. nao me atentei a tag main mesmo. vou fazer outros desafios pra praticar mais ja que comecei a pouco tempo a estudar

  1