Skip to content
Submitted 3 months ago

Pagina responsiva creada con HTML5, CSS y validada con JavaScript.

JJorgeMS13•440
@JJorgeMS13
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Newsletter sign-up form with success message
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Me encanto poder validar mi formulario solo con JavaScript, la proxima vez buscaría hacer mi codigo mas limpio.

What challenges did you encounter, and how did you overcome them?

Encontre el reto de cuando cambiaba de tamaño mi desarrollo y cambiaba de la ventana logueo a la ventana del mesaje de gracias me mostraba las dos ventanas al mismo tiempo y no importaba que tenia una clase para que una de ellas desapareciera lo que hice fue poner a mi porpiedad Display: none !import; para ganarle al display: flex; que le puse en el media query.

What specific areas of your project would you like help with?

Me encantaria que me ayuden a hacer un mejor codigo y poder aplicar las mejores tecnicas de codificación para hacer mucho mas facil una posible cambio en mi desarrollo.

Community feedback

  • rafi b•280
    @raficode2303Posted 3 months ago

    the solution include semantic HTML. the site looks the same as the solution. the code well-structured, readable, and reusable great for using FormData() at app.js

    to improve:

    • Success message page should be a different html page
    • the message text need to include the email that the user entered and not always '[email protected].'
    • the responsive of the page in the mobile mode need more improves include breakpoints. -- the image at 1023px is still of the desktop, but it need to be of the mobile.
    • bonus: try to use .card__info__list li::marke with style-image instead .card__info__list li::before keep to build 👷‍♂️
    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord