Design comparison
Solution retrospective
<h3>30-days,hassle-free money back gurantee</h3>
<p style="color:#333333;">Gain access to our sull library of tutorials along with expert code reviews.<br>perfact for any developers who are serious about honing skills.</p>
</div>
<div class="flex">
<div class="first">
<h4>Monthly Subscription</h4>
<div class="disable">
<span style="font-size: xx-large;">$29 </span><span style="color: #ebebeb; line-height: 20px ;">permonth</span>
</div>
<br>
<p>Full access for lass than $1 a day</p>
<button>Sign Up</button>
</div>
<div class="second">
<h4>Why Us</h4>
<p>Tutorials by industry experts <br>Peer & expert code review <br>Coding excercies <br>Access to our GitHub repos <br>Community fouram <br>Flashcard decks <br>New video every week</p>
</div>
</div>
</div>
</body>
</html>Community feedback
- Account deleted
Hey there! 👋 Congratulations on completing the challenge successfully! 🎉
I have some feedback on your code that I believe will help you improve its accessibility and organization. In your HTML, there are accessibility errors due to the use of non-semantic markup. To fix this, I suggest using semantic markup like the <main> element instead of the non-semantic <div class="main">. This will not only improve accessibility but also make your code more organized.
You might be wondering what a landmark is? Well, landmarks are used to define major sections of your webpage instead of using generic elements like <div> or <span>. They help convey the structure of your page to users, making it easier for them to navigate through it. The <main> element, for example, should include all content directly related to the main idea of the page and there should only be one per page.
Additionally, your code lacks a level-one heading <h1>, which is important for accessibility. Every webpage should have at least one h1 element to identify and describe the main content of the page. It's a vital navigation point for users of assistive technologies and should be added to improve accessibility. You can also add a sr-only class to hide it from visual users while making it available to visually impaired users.
I hope you find this feedback helpful in improving your code! 😄 Your solution is great, and keep up the good work!
Marked as helpful0 - @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to
non-semantic
markup, which lack landmark for a webpage
- So fix it by replacing the
<div class="main">
element with the semantic element<main>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, the
<main>
element should include all content directly related to the page's main idea, so there should only be one per page
HEADINGS ⚠️:
- And, this solution has also generated accessibility error report due to lack of level-one heading
<h1>
- Every site must want at least one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord