Design comparison
SolutionDesign
Solution retrospective
Please provide me tips on improving my code! I feel like I am missing on the best practices. Thank you so much.
Community feedback
- @mattstuddertPosted about 5 years ago
Nice work on this challenge, Ayesha! You've done a really good job with the overall layout. Here are a couple of tips after taking a look at your code:
- You're currently using multiple
h1
elements. I'd recommend only ever having a singleh1
on the page for accessibility reasons. I'd then use other heading levels to create a clear content hierarchy on the page. - I'd also recommend never using IDs for styling purposes. This is because they're too specific and they can't be reused on the page. Instead, I'd stick to class, attribute, pseudo and type selectors.
- Have you ever used
min-width
media queries instead ofmax-width
? They're great because they load in fewer styles for mobile users. Many developers actually prefer working mobile-first as well, so it might be worth a try in a future project!
I hope these tips help. Let me know if you have any questions!
0@ayeshanasirPosted about 5 years ago@mattstuddert Thank you so much! I will try to keep these tips in mind from here on now! :)
0 - You're currently using multiple
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord