Design comparison
Solution retrospective
Hello Guys, I really enjoyed coding this challenge.
Things I used for the first time: CSS Custom Properties, Transitions
Things I'm unsure of: Accessibility, Using lots of divs
Feel Free to give me any tips and suggestions regarding this challenge.
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hi Basit Korai, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
To prevent the background image from breaking at higher resolutions, we can prevent this in two different ways:
- Add a
background-repeat: repeat-x;
, the image will repeat on the horizontal axis, preventing it from breaking. - Add a
background-size: 100% 50vmin;
, the50vmin
will set its height as the page target, and100%
will make it stretch on the horizontal axis.
Feel free to choose one of the two!
Add a padding to the body, so that the content in lower resolutions doesn't hit the edge of the screen!
The rest is great!
I hope it helps... 👍
Marked as helpful1@basitkoraiPosted almost 2 years ago@AdrianoEscarabote Thank You for your feedback! Love you brother. I'll fix it.
1 - Add a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord