Atif Iqbal• 3,200
@atif-dev
Posted
Hi Jihane, congrats🎉 on completing the challenge. Better take care about following points.
- Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. To avoid accessibility issue "Document should have one main landmark" use code as :
<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
(why main
matters? Read here)
- Since we tackle responsive design in challenges so it is preferred to use
em
unit for padding and margin andrem
unit for font-size. For further info watch this video - When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.
- Include a README file in your GitHub project's solution and write about your working flow, findings, new learned things, useful resources, etc.
If the Feedback is Helpful for you, Don't Forget to upvote and click on MARKED AS HELPFUL 😇......That Will Make me feel Happy to Help someone😇
Marked as helpful
1