Design comparison
SolutionDesign
Community feedback
- @HcmwebsPosted over 1 year ago
Hi, This is a good solution; however, I believe you can make it better by;
- To the body, I should remove the margins and set it to display grid or flexbox with flex-direction to the column.
- including landmarks. After the container, the next element should be NOT a div but a MAIN and t FOOTER for the attributions class. These should solve the landmark issues.
I hope these pointers are helpful.
Regard,
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord