order-summary-component-main

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Max, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  0

  ---

  

  MaxSurawut•240

  @MaxSurawutPosted about 2 years ago

  @denielden

  Thank for your tips. I will do it on next projects really appreciate.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @MaxSurawut You are welcome and keep it up :)

  0