@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML π·οΈ:
- The
<picture>
tag can be useful when you need to provide different images for different viewports, but in this specific challenge, it's not necessary. You can directly use the<img>
tag to include the image in your solution.
-
The
<article>
tag is used to mark up self-contained, independent content that makes sense on its own and can be syndicated or shared on its own. This allows the content to be understood by users even when it is viewed outside of the context of the original website.In summary, in your solution there is no need to add any <article> tag.
CSS π¨:
- Using both
min-width
andmax-width
with the same value doesn't make sense, there is no value between those values, so it is the same as usingwidth
. The only one that should exist ismax-width
and not both.
- Use
min-height: 100vh
instead ofheight
. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.
CSS Reset π:
-
You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.
CSS resets that are widely used:
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@mortalcode
Posted
@MelvinAguilar Thankyou so much for taking time, going through my code and suggesting these amazing points. really helpful!