Design comparison
Solution retrospective
All comments are welcome. If you have any comments about the solution, please, let me know in the comments below
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hello sohail mahmoud, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:
To prevent the background image from breaking at higher resolutions, we can prevent this in two different ways:
- Add a
background-repeat: repeat-x;
, the image will repeat on the horizontal axis, preventing it from breaking. - Add a
background-size: 100% 50vmin;
, the50vmin
will set its height as the page target, and100%
will make it stretch on the horizontal axis.
Feel free to choose one of the two!
avoid using
px
, If your web content font sizes are set to absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. if you want to keep using px for development and then format the whole code to rem, you can use this vscode extension: px to remThe remainder is excellent.
I hope it's useful. 👍
0 - Add a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord