order-summary-component-main

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @UnderdogScripter 👋🏻

  I just have a quick tip, for the music icon, add aria-hidden="true", because it's for decoration. You can read more about aria-hidden here.

  I hope this was helpful 👨🏻‍💻 you did a great job with responsiveness. Cheers 👾

  Marked as helpful

  1

  ---

  

  Mohamed-G•205

  @UnderdogScripterPosted about 3 years ago

  @kens-visuals Do we use that attribute every time we use a decorative icon? I thought if there's no "alt" text it would be automatically ignored, is that true? Also thanks for the feedback, appreciated

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @UnderdogScripter this is the short list that MDN provides

  • purely decorative content, such as icons or images
  • duplicated content, such as repeated text
  • offscreen or collapsed content, such as menus

  No, if there's no alt it would throw an error.

  You're welcome 😇

  Marked as helpful

  1

  

  Mohamed-G•205

  @UnderdogScripterPosted about 3 years ago

  @kens-visuals Thanks! Didn't know menus should be hidden too, one last question... What if menus contain important navigational links? Do we use JS to toggle between true and false for aria-hidden?

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @UnderdogScripter absolutely correct

  0