Design comparison
Solution retrospective
2nd attempt, what else can I improve on?
Community feedback
- @DavidMorgadePosted over 2 years ago
Hello Luis, great job completing the challenge, you did a great job and it seems that you are improving a lot!
Here are a few advice that you can take for future projects.
Use a CSS reseter to remove the default styles of the browsers, do you see that your body has a random
margin
even when you didn't use margin on your body? thats because some browsers have default CSS styles, to remove them just use nomalize.css, link it to your html and you will see how those annoying styles are gone.Also would recommend you to remove your
card__text
div
, you don't need a div there, you just place your text and paragraph and is all good!Apart from that you did a great job with the responsive design for mobiles using
max-width
on your container, go ahead and move on to a harder challenge and keep improving!Hope my feedback helps you!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord