Order-Summary-Component

Community feedback

• 

  Tharun Raj•1,330

  @Code-BeakerPosted 6 months ago

  Hi there, congratulations on completing this project, you've done a great job! 🎉

  This might not be the help you've specifically asked for but, I would like to put forward some of my suggestions regarding your HTML and CSS.

  • instead of using a div for the buttons, use either an a(anchor) or button tags. They are more accessible to the users. This will also reduce a few lines of code for you.

  Apply this to:

  • "Change" link
  • "Proceed to payment" button
  • "Cancel Order" link

  Instead of:

  <div class="payment-button">
    <p id="PTP">Proceed to Payment</p>
  </div>
  

  You can try using:

  <button class="payment-button">Proceed to Payment</button>
  

  or:

  <a href="#" class="payment-button">Proceed to Payment</a>
  

  These make much more sense for a button.

  • instead of height use a min-height for the container:

  .container {
  min-height: 100vh;
  }
  

  • use rem instead of px for: rem is more of a flexible unit when it comes to making responsive websites.

  • font-size

  • padding

  • margin If you want to learn further, check this article.

  Hope this helps you improve your solution! 😄

  Marked as helpful

  0

  ---

  

  Nathan B•110

  @natebe4Posted 6 months ago

  Thank @Code-Beaker ! I am still learning. I will take that all into consideration when i get further into learning this stuff! I truly appreciate the comments and help! Thank you!

  1

  

  Tharun Raj•1,330

  @Code-BeakerPosted 6 months ago

  Glad I could help, @natebe4 😃

  0

  

  Nathan B•110

  @natebe4Posted 6 months ago

  @Code-Beaker just an fyi. i did update code on this project on github if youd like to see some of the changes i made.

  1

  

  Tharun Raj•1,330

  @Code-BeakerPosted 6 months ago

  Sure, @natebe4

  0