Skip to content
Submitted over 1 year ago

Order-Summary-Component using HTML and raw CSS and Javascript

Scott Tabor•150
@scottttabor
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Another pretty basic challenge. Thanks to some people on here giving me tips and tricks as I go along have helped me organize my code better and have some better practices in my code! Thank you everyone for that. Feel pretty confident on this one, but if anyone wants to check out my code and give some feedback it would be much appreciated! Haven't messed around with adding those background SVG shapes before, but I learned how to tweak the background properties on elements.

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    COMPONENT MEASUREMENTS 📐:

    • Use min-height: 100vh for main instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.
    • For example; if we set height: 100vh then the main will have 100vh height no matter what. Even if the content spans more than 100vh.
    • But if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    1
    Scott Tabor•150
    @scottttaborPosted over 1 year ago

    @0xAbdulKhalid oh yes, great point! I believe I followed that principle for the rest of the component except that main tag itself, haha. Thank you for the tip!

    0
    Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    @scottttabor Glad you found it helpful ! 🤠

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord