Order-summary-component using Flex

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Awesome work with this one. Looking at your solution, I think you should considered the following as well...

  • Add the background image in the body rule set with background-position:top and background-size: cover/contain;
  • Include description with the alt in img tag
  • Remove the commented code like to keep it clean

  Overall you did well. Hope this helps and Keep it going!

  Marked as helpful

  1

  ---

  

  Mohamed Fathy•160

  @M0hamedFPosted almost 3 years ago

  @RioCantre I forgot all about the background image 😂. I will add it and remove unnecessary comments 👍

  1
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Good Job Mohamed Fathy

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body like it should be your container. For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc . But use header tag only once in main heading element.

  -> Always use h1 first and then h2, h3 and so on

  Keep up the good work!

  Marked as helpful

  1

  ---

  

  Mohamed Fathy•160

  @M0hamedFPosted almost 3 years ago

  @Crazimonk So all I have to do is adding h# to every section got it 👍. Thanks

  1
• 

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted almost 3 years ago

  Your solution looks great keep it up👍

  1

  ---

  

  Mohamed Fathy•160

  @M0hamedFPosted almost 3 years ago

  @Kamasah-Dickson Thanks 👍

  0