Design comparison
Solution retrospective
I welcome any feedback or suggestions that will help me improve my code
Community feedback
- @madkn1311Posted over 2 years ago
Hello,
Your design looks as good as the original one. :)
I saw your code and you need to make very minor changes, first of all, you need to add the lang="en" in your HTML tag. And then you need to use the h1 heading instead of h2. The headings should always start with h1, h2, and so on. I'm sure if you make these changes the issues in the code will be resolved.
I hope this was helpful.
Marked as helpful0@Nada-El-shaterPosted over 2 years ago@madkn1311 it is really helpful thank you so much <3
0@madkn1311Posted over 2 years ago@Nada-El-shater you're welcome...!! :)
Marked as helpful0 - @vanzasetiaPosted over 2 years ago
Hi! 👋
Good effort on this challenge! 👍
I have a few suggestions for this solution.
- I only notice the
:hover
effect for the "Cancel Order" link. I recommend adding some:hover
styling to the interactive elements. - Always specify the
type
of thebutton
. In this case, set the type of them astype="button"
. It's going to prevent the button from behaving unexpectedly.
Hope this helps.
Marked as helpful0@Nada-El-shaterPosted over 2 years ago@vanzasetia thank you very much vanza it's really helpful <3
0 - I only notice the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord