Design comparison
Solution retrospective
Hello!
This is my 4rth challenge any feedback is very welcome, can someone tell me if it is necessary to give a height to the card or should I let it expand according to its content?
Thank you!
Community feedback
- @vanzasetiaPosted over 1 year ago
Hi, Carlos!
You don't need to specify the height of the card. Let the content controls it. This way, if the content of the card gets updated, the height will automatically adjust to fit the content.
The illustration and the music icon are decorative images. They don't add any information and serve only aesthetic purposes. So, leave the alternative text empty.
Don't change the
<html>
or the:root
font size. It can cause huge accessibility implications for those users with different font sizes or zoom requirements.- Grace Snow explains the issue clearly — Should I change the default HTML font-size to 62.5%?
- Joshua Comeau also does not recommend that approach — The Surprising Truth About Pixels and Accessibility: should I use pixels or rems?
I hope this helps.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord