Design comparison
Solution retrospective
This is my third challenge so if there is anything that can be improved please let me know. Thanks a lot. Any general feedback would be appreciated
Community feedback
- @farukwebcode21Posted almost 3 years ago
Thank for your I forget use instruction font , really sorry again thanks for your suggestion
0 - @zytuuPosted almost 3 years ago
Hey there! Great looking solution and I'm glad that you're asking for feedback on your project. First of all, well done on achieving such a well proportioned card, that looks almost identical to the original's size.
As for things to work on, try using the font they provide you with in the styleguide.md file. I noticed you used the background image too, but you forgot to set the color of the actual <html> or <body> tag in your CSS so it just falls short of looking identical. The last bit of feedback I have is to try using the BEM naming conventions (if you're confused Kevin Powell has a really good video on it, I suggest checking that one out.), it makes working with nested divs (like the ones in ur card) a ton easier.
I hope I could help, and I hope we can both keep improving our skills on frontendmentor!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord