Design comparison
SolutionDesign
Solution retrospective
Suggest fixes if you see any problems
Community feedback
- @RioCantrePosted almost 3 years ago
Hello there! Good job making this project. To fixed some of the issues I would suggest the following for you...
- Inside the
body
tag add padding and margin with the value of 0 - Add
margin-top: 5rem;
inside the.flexbox-container
rule set - Eliminate the
position: fixed;
in theattribution
to align the text in the center - Wrap the
attribution
withfooter
tag - Use
main
tag to wrap thecontainer
for readability - Use a validator to check your solution
Hope this helps and Keep going!
Marked as helpful1@RioCantrePosted almost 3 years ago@akaditya394 No worries! I would appreciate it if you could mark it as helpful
1 - Inside the
- @denieldenPosted almost 3 years ago
Hi ADITYA, good job!
I had a look at your solution and I have a few suggestions to improve your code:
- remove margin from
body
- For center the card give
align-items: center;
property to the.container
class. - To fix the position of the top photo in the background add these properties to the
container
class:
background: url("images/pattern-background-desktop.svg") no-repeat top center; background-size: contain; background-color: #e0e8ff;
- Try to adding a little
transition
on the buttonhover
effect
Happy coding!
Marked as helpful1 - remove margin from
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord