Order-summary-component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Abdelrhman, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • add descriptive text in the alt attribute of the image
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • For add the top image in the background just put more specific background properties to the body:

  background: url("../img/pattern-background-desktop.svg") no-repeat top center;
  background-size: contain;
  background-color: #e0e8ff;
  

  Overall you did well 😉

  Hope this help and happy coding!

  Marked as helpful

  1

  ---

  

  Abdelrhman Kamal•450

  @AbdelrhmanX7Posted over 2 years ago

  Thanks for taking out time to go through my solution.

  Your suggestions are very helpful.

  Thank you! 😊@denielden

  1