Design comparison
Community feedback
- @RichardOgujawaPosted about 2 years ago
Hey Kaysiwill,
Hope you're keeping well. Really like the code you've written man. Just have one minor tweak I would recommend which I learned from one of Kevin Powell's videos which I think would benefit you too.
I'd recommend not using the hsl function in your color variables. You're better off just using the values (i.e. '--soft-blue: 215, 51%, 70%' instead of '--soft-blue: hsl(215, 51%, 70%)'). This will allow you to later add an alpha value if needs be. For example, if you wanted the soft-blue colour to be slightly transparent, but used the variables the way you've written it, you wouldn't have that flexibility to do so. However, if you only used the values, then you could do something like this. 'color: hsl(var(--soft-blue), 50%)'
Hope this helps:)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord