Order-summary-component

Community feedback

• 

  eruj22•410

  @eruj22Posted about 2 years ago

  Hi Mihailescu,

  good job on getting back on track and keep coding. Your solution looks good when implemented and you can improve your code even more. First thing to work on is HTML semantics. In your case class card-summary would have article and children inside would mostly be divs. You shouldn't use section inside this card element, but card element can be used inside section. Try to go through MDN reference of HTML semantics to really understand why and when to use different ones. Second thing that you can improve is making classes more clear, structured. There are many ways to do it, one of them is using BEM (follow link to learn more: https://sparkbox.com/foundry/bem_by_example). With a more structured approach you make it easier and clearer to apply styles to components, you can better avoid clashing of class names in bigger projects and other people will have easier time managing the same code (+ your future self).

  Keep coding and focus on the fundamental. Enjoy

  Marked as helpful

  0

  ---

  

  P

  Mihailescu Fanush•690

  @FanushhhPosted about 2 years ago

  @eruj22 Thanks a lot for the feedback, I'll definitely do a research on HTML semantics and class structure, I feel like that's one important thing to know in order to write clean and understandable code.

  0