Design comparison
Solution retrospective
Hello,
Should the code be presented in this way or are there elements missing?
Are the html and css codes written correctly or should they be coded differently?
Sincerely,
Community feedback
- @rakshithjodukalluPosted about 2 years ago
Hey, Go through Your work and its amazing. checked your design and solution its 100% matching. Only one thing recognised as for mobile view its not responsive, hope you will fix this. keep posting your design like this mate.
Marked as helpful0@SlideurPosted about 2 years ago@rakshithjodukallu
Hello, thank you for your comment. I have done the responsive. It doesn't work on your screen?
0 - @VCaramesPosted about 2 years ago
Hey @Slideur, great job on this project!
Some suggestions to improve you code:
For accessibility purposes, its better to use rem/em instead of px for your CSS property values.
To help keep your CSS code organized and easier to use, I suggest implementing CSS Variables. This will come in handy when building large websites, using light/dark mode, etc…
It’ll look something like this:
:root { --primary-color: value; --secondary-color: value; --tertiary-color: value; }
And to use the variables you’ll use the var() function. So it’ll look like this.
h1 { color: var(—primary-color); }
Heres are some articles regarding CSS Variables.
You can also take a look at my projects and see how I use it.
https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties
https://www.w3schools.com/css/css3_variables.asp
Happy Coding!
Marked as helpful0@SlideurPosted about 2 years ago@vcarames
Thank you very much for your comment. You have taught me a few things. I will use variables in the future. I will also use rem or em. I will read the articles you have suggested. I have seen your projects, I will read the way you have built them. Thank you again for all this. it was very kind of you to take the time to explain these things to me.
Happy coding too !
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord