Design comparison
SolutionDesign
Solution retrospective
hope this okay 😁👌
Community feedback
- @darryncodesPosted about 3 years ago
Hi Walmanjm,
You've smashed it, well done!
- you could clear up your accessibility report though. Change
<div class="container">
to<main class="container">
and<div class="attribution">
to<footer class="attribution">
semantic html is reall important - also your design should have one
<h1>
and you shouldn't skip heading levels
All the best!
Marked as helpful0@walmanjmPosted about 3 years ago@darryncodes thanks a lot, very much appreciate 👍,
point to improve :
- semantic html
- heading levels
this is helpfull
0@walmanjmPosted about 3 years ago0@darryncodesPosted about 3 years agonice one @walmanjm, looks great! Good to see you've implemented the feedback already. You should have the option to refresh the accessibility report to get rid of those errors now you've fixed them.
0 - you could clear up your accessibility report though. Change
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord