Order-summary-component

Community feedback

• 

  RAJPUT CHIRAGSINGH ARJUNSINGH•50

  @RajputChirag27Posted over 1 year ago

  I reviewed your code and have some suggestions for improvement:

  1.Add comments to your code: Comments make your code more readable and understandable for other developers who may review or collaborate with you on the project. Consider adding comments that explain the purpose of each section of code and how it works.

  2.Use semantic HTML: Semantic HTML helps make your code more accessible and improves SEO. For example, you can use the <header> tag for the header section of your code, <nav> tag for navigation links, <main> tag for the main content of your page, and <footer> tag for the footer section of your page.

  3.Use more descriptive class names: While your current class names are functional, they could be more descriptive. Consider renaming some of your class names to more accurately reflect their purpose. For example, instead of using card for the main content container, you could use summary-container.

  4.Consolidate styles: You can consolidate styles by grouping similar styles together and avoid duplicating styles across different classes. This will make your CSS code more organized and easier to maintain.

  5.Make your code responsive: Currently, the layout of your code works well on larger screens but could be improved for smaller screens. Consider using media queries to adjust the layout for different screen sizes.

  Overall, your code is well-structured and easy to understand. With the suggestions above, you can make it more readable, maintainable, and user-friendly. Good luck with your project!

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HEADINGS ⚠️:

  • This solution has generated accessibility error report due to skipping heading levels

  ---

  • We want to avoid skipping heading levels, make sure to start with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that our document has a clear and consistent hierarchy. Read more 📚

  ---

  • Because skipping heading levels is a poor practice from the perspective of information design, whether we are talking about web pages, books, journal articles, or about anything else. You can not only confuse screen readers but all readers when you don't follow a consistent, logical pattern with your heading structure.

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0