@correlucas
Posted
👾Hello @olisa187, Congratulations on completing this challenge!
I like the work you’ve done here, your solution is almost complete. I’ve some suggestions for you to improve the code/design:
1.Replace the <h2>
containing the main title with <h1>
note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
2.Fix the alignment. The best way make this alignment is by using FLEXBOX
. The first step, is to add min-height: 100vh
to make the body height size becomes 100% of the viewport height, this way you make sure the container will be aligned vertically since the body
will display ever 100% of the screen height. After that add two flex properties to make the alignment display: flex
/ align-items: center;
/ justify-content: center;
. If you're using the attribution you need to add flex-direction: column
to make the attribution stays under the QR Code component. See the code below:
@media (min-width: 23.5em)
body {
min-height: 100vh;
background-image: url(images/pattern-background-desktop.svg);
background-repeat: no-repeat;
display: flex;
align-items: center;
justify-content: center;
flex-direction: column;
}
Remove the paddings:
@media (min-width: 23.5em)
main {
/* padding-top: 10em; */
}
main {
max-width: 90em;
margin: 0 auto;
/* padding: 4em 1em 2em 1em; */
}
✌️ I hope this helps you and happy coding!
Marked as helpful