Skip to content
Submitted over 2 years ago

order-summary-component

Maria•130
@maaghia
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I got a little bit confused with th edimentions of components, I might try to adjest them in a second trial. All your comments are wellcome.

Community feedback

  • Hamzat Lawal•560
    @EngineerHamzieyPosted over 2 years ago

    Hello Maria, You have done a great work You have some accessibility issues, to fix them:

    • Always add the language attribute to you <html> tag, it should look like <html lang="en"> and here en = English. You can out your preferred language.
    • your attribution should always be inside the Landmark footer tag I.e you should have
    <footer>
    <div class="attribution">
      Challenge by <a href="https://www.frontendmentor.io? 
      ref=challenge" target="_blank">Frontend Mentor</a>. 
     Coded by <a href="#">Toubal Maria</a>.
   </div>
</footer>
    • Your design looks great 😊, try to add some padding/margin-top for the attribution. In short add some more spacing between them.

    I hope you found this helpful 😊

    1
  • Maria•130
    @maaghiaPosted over 2 years ago

    This was very helpful, thank you

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord