@dimar-hanung
Posted
Hi.. š, Congratulations on completing the challenge š .
I have some interest and feedback with your code
That i like:
- I appreciate the similarity of your results with the design, a bit different but still good
- html is pretty good, not too nested š
My Feedback:
-
I suggest you use html semantic convention, for example
<div class="main-container">
to<main class="main-container">
, it will make it clearer, and will improve seo if you want to submit your website to google, i recomended this article: here -
Your css naming still doesn't represent its use, for example
<div class="item2">Proceed to payment</div>
can be<button class="button-primary">Proceed to payment</button>
-
you can seperate file by folder to be more structured, for example:
public/
āā images/
ā āā illustration-hero.png
ā āā pattern-background-mobile.svg, etc..
āā styles/
ā āā main.css
āā favicon.png
index.html
anyways overall is good, nice solution, hope it useful š
Marked as helpful