Order-summary card

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay There ! Good Job on this challenge

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body like it should be your container

  -> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc

  -> But use header tag only once in main heading element.

  -> Always use h1 first and then h2, h3 and so on

  Keep up the good work!

  1

  ---

  

  adr99•410

  @leorichy99Posted almost 3 years ago

  @Crazimonk

  Thank you 🤩

  1
• 

  Omar M.•270

  @OmarMAttia7Posted almost 3 years ago

  Congratulations on finishing the challenge :). Your is code has some problems with HTML Markup and CSS:

  1. The main content of your document should be wrapped inside a <main> element or something equivalent, in this case it's preferable that you give it class="container" instead and delete the <div class="container"> you have as it has no use
  2. The alt attribute of your images should have a meaningful description of the image for people who can't view it visually, you shouldn't leave them empty.
  3. All HTML documents should have an <h1> element, in this case your Order Summary should be an <h1> instead of an <h3>, you can change the font-size with CSS.
  4. The Proceed to payment and Cancel Order are user interactions so they should be appropriate semantic elements like <button>s or <a>s to avoid accessibility issues.
  5. You should use percentages and ems whenever possible instead of pixels because some users will scale the website to their own preference and you want it to look OK for them.
  6. The hero image should usually be added using CSS backgrounds instead of HTML <img> as it is there for decoration.
  7. Finally your CSS could use some organization, consider commenting your css files and using a naming methodology like the BEM method. Good luck and keep coding <3.

  1

  ---

  

  adr99•410

  @leorichy99Posted almost 3 years ago

  @hazel79

  Many thanks brother

  Well noted 👌

  0
• 

  Abhik•4,840

  @abhik-bPosted almost 3 years ago

  👋 Hello Richmond , Your solution is very responsive & looks cool. I liked the descriptive HTML markup you wrote & I liked the transitions as well 🤩 I agree with all the above comments .

  Well Done 🤩🤩🤩 Please Keep coding this amazing solutions & Happy Saraswati Puja ❤️

  0

  ---

  

  adr99•410

  @leorichy99Posted almost 3 years ago

  @abhik-b

  Thanks brother 🤩 I appreciate that

  1

  

  adr99•410

  @leorichy99Posted almost 3 years ago

  @abhik-b

  Thanks brother 🤩 I appreciate that

  1