Order-smry-card using flexbox media querry

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, awesome work on this one. Layout in general looks great.

  Some suggestions would be:

  • No need to set width: 100%on the body since it is a "block" element, it already uses 100% at default.
  • The vector-image should have used alt="" on it and an extra aria-hidden="true", since it is a decorative image, you want it to be hidden.
  • I see lots of id usage on this one. This is a bad practice especially when you are using them as a styling selector. Use class instead of id to target elements to style.
  • Music-icon should be hidden as well, alt="" and aria-hidden="true", also when using alt, avoid adding words that relates to "graphic" such as "icon, image, logo.." it is already an image so no need to describe it as one.
  • annual-plan could have used a heading tag.
  • Also, when there is a text-content, you don't just wrap them by div or an span, make use of meaningful element like p tag to wrap those.

  Aside from those, great work again on this one.

  Marked as helpful

  0

  ---

  

  Divyank Dubey•60

  @dubeydivyankPosted about 3 years ago

  @pikamart Thank you! I will definitely try to implement your suggestions.

  0
• 

  SHAHAB MALIK•345

  @Shahab-MalikkPosted about 3 years ago

  Hi nice work implemented things well Keep Coding

  0

  ---

  

  Divyank Dubey•60

  @dubeydivyankPosted about 3 years ago

  @shahabmalik996 Thank you! :)

  0