Order-Component

Community feedback

• 

  Sanja Jovičić•410

  @Sanja24ItPosted 10 months ago

  Thanks, that helps! 😉

  0
• 

  raya•2,850

  @rayaattaPosted 10 months ago

  Hi congrats completing this challenge 🎉 I have some simple tips that can improve your code. 1.Technically you used <div class="attribution"> but since divs have no meaning to assistive technology it would be a whole lot better if you used <footer class="attribution">. Another issue a div and a footer are sectioning elements so you shouldn't put text in them directly. You should wrap the attribution text inside e a <p> element inside the footer. 2. It's much recommended to insert a link to your fonts inside the html instead of the css. 3.you also should also add this code snippet into your code

  *{
  box-sizing:border-box;
  }
  

  in future projects you will have to also add

  padding:0;
  margin:0;
  

  These declarations override default spacing enabling you to have more control over the document`s layout.

  I hope this helps Your solution is epic🤩 Happy coding🙃

  0