Design comparison
SolutionDesign
Solution retrospective
App made with React, pure CSS and responsive design. Any feedback is welcome.
Community feedback
- @kens-visualsPosted about 3 years ago
Hey @marcoariasm 👋🏻
I have some quick tips to help you fix the accessibility and HTML issues.
- In your markup,
<div class="card">...</div>
should be<main class="card">...</main>
and . - Next,
font-weight: 500px
is not a properfont-weight
value, so all you need to do is just removepx
, like so, ``font-weight: 500`. These will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues. - For the music icon, add
aria-hidden="true”
, because it's for decoration. You can read more aboutaria-hidden
here. - Also, I suggest adding
transition: all 0.2s;
to the button and the links, this will make:hover
smoother.
I hope this was helpful 👨🏻💻 other than that, you did a great job for your second project, well done. Cheers 👾
0 - In your markup,
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord