Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Yannmarc, good job! I took some time to look at your code and have some ideas for improving it:
- For fix the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center; background-size: contain; background-color: #e0e8ff;
- add descriptive text in the
alt
attribute of the image - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - use
h1
for title of card and noth3
- add
background: transparent
to Cancel Order button - remove all
margin
frommain
tag because with flex they are superfluous
Overall you did well 😉
Hope this help and happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord