Design comparison
SolutionDesign
Solution retrospective
What do you think about my code ??Do I have to make any changes to the code Regardless of length and width?
Community feedback
- @vanzasetiaPosted about 3 years ago
👋Hi Medjahdi Islem!
👍Good job on completing your first challenge! I am going to give some feedback on this solution:
- All images always needs
alt=""
attribute. You can leave thealt
empty for all decorative images. - Heading order is extremely important.
- For the Annual Plan, it should never be a heading tag. I recommend to use
strong
instead. - In this case, you shouldn't limit the
height
of thebody
element. Usemin-height
instead. - The card is touching the top of the page, try to move it down.
- I would highly recommend to use flexbox to center the card both horizontal and vertical of the page.
- Use
rem
or sometimesem
units instead ofpx
. Usingpx
will not allow the user to scale the size of your page based on their needs.
That's it! Hopefully this is helpful!
Marked as helpful1@IslemMedjahdiPosted about 3 years ago👋Hi @vanzasetia ! Thank you very much😍, it really helped me I am excited to use your feedback for upcoming challenges and projects🥰
0 - All images always needs
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord