Order- Summary

Community feedback

• 

  Abdihafid Adan•800

  @Abdul400Posted about 3 years ago

  hello yaredh30. Generally, I think it looks really good and you are almost perfect. However, I noticed some issues with responsiveness especially for smaller devices. Also, there is no music icon in the plan section. The dimensions are also a little bit off. I think other than that, it looks great.

  Marked as helpful

  1

  ---

  

  Yared•90

  @yaredh30Posted about 3 years ago

  @Abdul400 Thank you so much for the feedback Abdul! Yea I'm not too familiar with responsive designs like media queries, but I'll make sure to learn that for my next project. I just noticed that I missed the music Icon.. I really appreciate the positive feedback!

  0
• 

  Ediongsenyene Joseph I.•1,675

  @IEdiongPosted about 3 years ago

  Hello, congratulations on completing your first challenge. Some things I noticed that can be improved are;

  • the use of position: absolute; on the .container class is not the best. HTML is responsive on it's own so you need to work from there
  • use display: flex; or display: grid; to center block (ie <div>, <section> etc) on your page
  • you missed the music icon
  • the proceed to payment button should have a box-shadow
  • you could also look into the accessibility and HTML issues raised here.

  I hope this was helpful. Shalom!

  1

  ---

  

  Yared•90

  @yaredh30Posted about 3 years ago

  @IEdiong Thank you so much for your feedback Shalom! I just noticed that I missed the music icon. What's the difference between position: absolute and display: flex though? I'll definitely look into accessibility and HTML issues! Thanks again for the feedback!

  0

  

  Ediongsenyene Joseph I.•1,675

  @IEdiongPosted about 3 years ago

  @yaredh30 display: flex; is a better way of doing CSS layout. You should look into it. I would recommend you checkout Kevin Powell's YouTube playlist on it, it really explains it.

  After learning about flexbox, the next thing you should learn with regards to layout is CSS Grid. There are a ton of resource online for you to learn from.

  Marked as helpful

  0

  

  Yared•90

  @yaredh30Posted about 3 years ago

  @IEdiong I appreciate you my guy! I got a lot to learn about CSS

  0