@vanzasetia
Posted
Hi, Mohan! π
Congratulations on finishing this challenge! π
The way I would make the card responsive is simply use max-width
and overflow: hidden
. The max-width
is used to prevent filling the entire while still allowing it to shrink. For, the overflow: hidden
is used to force the illustration image to obey the border-radius
of the parent element.
For the CSS reset, I recommend using the "Modern CSS Reset" by Andy Bell. His CSS reset is good for modern browsers and accessibility.
Also, I recommend using the universal selector (*
) rather than selecting and listing all HTML elements.
One more suggestion is to always specify the type
of the button
. In this case, set the type of them as type="button"
. It will prevent the button from behaving unexpectedly.
That's it! I hope this helps!
Marked as helpful
@Mohan823
Posted
@vanzasetia Verymuch thank you for the valuable feedback. Today onwards when i m creating button i won't forget to mention it's type.π
@vanzasetia
Posted
@Mohan823 No problem! π