Design comparison
Solution retrospective
rate me ? is there any problem in my code ?
Community feedback
- @darryncodesPosted almost 3 years ago
Hi Mohssine,
Great little design there.
I'd recommend removing
background-position-y: -60%;
and addingbackground-size: 100% auto;
to better match the challenges design.All the best!
Marked as helpful1@mohssineoussamaPosted almost 3 years ago@darryncodes i will do and see , thanks anyway
0@mohssineoussamaPosted almost 3 years ago@darryncodes u have right it better now , i appreciate it
0 - @hatwell-jonelPosted almost 3 years ago
Hi! congratulations for finishing this challenge. there are some issue that saw checking your html code you must use anchor tag <a> to the webpage when you are link to a certain content so you must change the "proceed to payment" button to anchor tag. also there are issues in the accessibility you can check that on the report page.
Article on correct using of anchor tag:
https://medium.com/design-code-repository/a-vs-button-b859547cae4d
keep coding 👍👍
Marked as helpful1@mohssineoussamaPosted almost 3 years ago@hatwell-jonel thanks for your comment i will work on my mistakes thanks again
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord